Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Convert get_mock_dataset fn in AmazonReviewPolarity to be private #1543

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Convert get_mock_dataset fn in AmazonReviewPolarity to be private #1543

merged 2 commits into from
Jan 28, 2022

Conversation

@Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Jan 27, 2022

  • [minor] Convert get_mock_dataset fn in AmazonReviewPolarity to be private since it's only used for dataset testing

parmeet
parmeet approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nayef211 Nayef211 merged commit 169924b into pytorch:main Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abhinavarora abhinavarora Awaiting requested review from abhinavarora

2 more reviewers

@mthrok mthrok mthrok approved these changes

@parmeet parmeet parmeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/default cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nayef211 @mthrok @parmeet @facebook-github-bot