[Nova] Passing Torchvision Smoke Test to build workflow #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@osalpekar is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
seemethere
reviewed
Nov 3, 2022
| ${CONDA_RUN} conda install -y 'ffmpeg<5' | ||
| if [[ "${{ inputs.package-name }}" = "torchaudio" ]]; then | ||
| ${CONDA_RUN} conda install -y 'ffmpeg<5' |
Member
There was a problem hiding this comment.
Shouldn't this be a part of the repository specific verification scripts?
Member
Author
There was a problem hiding this comment.
Repo-specific validation scripts are currently just python scripts. I'm going to add shell scripts that install the necessary run-time deps for running the smoke tests soon, this is just a stop-gap.
seemethere
approved these changes
Nov 4, 2022
kit1980
pushed a commit
that referenced
this pull request
Nov 23, 2022
Pass Smoke Tests to test workflows. Also fix mac conda smoke tests and remove the double-installation of pytorch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass Smoke Tests to test workflows. Also fix mac conda smoke tests and remove the double-installation of pytorch.