Skip to content

[Nova] Passing Torchvision Smoke Test to build workflow #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 4, 2022
Merged

[Nova] Passing Torchvision Smoke Test to build workflow #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
80851ee
[Nova] Passing Torchvision Smoke Test to build workflow
osalpekar Oct 31, 2022
16ac7bb
pytorch should not be installed twice during smoke testing
osalpekar Oct 31, 2022
2b608c3
fix error with passing smoke test to windows post script
osalpekar Nov 1, 2022
ed72930
dont install ffmpeg for every domain
osalpekar Nov 1, 2022
6cd0caa
try non-offline install in the smoke tests to see if it pulls down numpy
osalpekar Nov 2, 2022
85bf314
typo
osalpekar Nov 2, 2022
92821f8
do explicit numpy install
osalpekar Nov 2, 2022
9aff0ba
remove comment
osalpekar Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/build_conda_macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,15 +160,18 @@ jobs:
echo "${{ inputs.repository }}/${SMOKE_TEST_SCRIPT} not found"
else
echo "${{ inputs.repository }}/${SMOKE_TEST_SCRIPT} found"

${CONDA_RUN} conda install -y pytorch -c pytorch cpuonly

CONDA_BINARY="$(ls ${{ inputs.repository }}/dist/${ARCH_NAME}/*.tar.bz2)"

${CONDA_RUN} conda install -v -y -c pytorch-nightly pytorch
${CONDA_RUN} conda install --offline "$CONDA_BINARY"

${CONDA_RUN} conda install -y 'ffmpeg<5'
if [[ "${{ inputs.package-name }}" = "torchaudio" ]]; then
${CONDA_RUN} conda install -y 'ffmpeg<5'
Copy link
Member

@seemethere seemethere Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a part of the repository specific verification scripts?

Copy link
Member Author

@osalpekar osalpekar Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo-specific validation scripts are currently just python scripts. I'm going to add shell scripts that install the necessary run-time deps for running the smoke tests soon, this is just a stop-gap.

fi
if [[ "${{ inputs.package-name }}" = "torchvision" ]]; then
${CONDA_RUN} conda install -y 'numpy>=1.11'
fi

${CONDA_RUN} python3 "${{ inputs.repository }}/${SMOKE_TEST_SCRIPT}"
fi
- name: Upload package to conda
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_build_conda_linux_with_cuda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- repository: pytorch/vision
pre-script: ""
post-script: ""
smoke-test-script: ""
smoke-test-script: test/smoke_test.py
conda-package-directory: packaging/torchvision
package-name: torchvision
name: ${{ matrix.repository }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_build_conda_m1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
pre-script: ""
post-script: ""
conda-package-directory: packaging/torchvision
smoke-test-script: ""
smoke-test-script: test/smoke_test.py
package-name: torchvision
- repository: pytorch/text
pre-script: ""
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_build_conda_macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
pre-script: ""
post-script: ""
conda-package-directory: packaging/torchvision
smoke-test-script: ""
smoke-test-script: test/smoke_test.py
package-name: torchvision
- repository: pytorch/text
pre-script: ""
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_build_wheels_linux_with_cuda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- repository: pytorch/vision
pre-script: ""
post-script: ""
smoke-test-script: ""
smoke-test-script: test/smoke_test.py
package-name: torchvision
uses: ./.github/workflows/build_wheels_linux.yml
name: ${{ matrix.repository }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_build_wheels_m1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- repository: pytorch/vision
pre-script: ""
post-script: ""
smoke-test-script: ""
smoke-test-script: test/smoke_test.py
package-name: torchvision
- repository: pytorch/text
pre-script: ""
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_build_wheels_macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- repository: pytorch/vision
pre-script: ""
post-script: ""
smoke-test-script: ""
smoke-test-script: test/smoke_test.py
package-name: torchvision
- repository: pytorch/text
pre-script: ""
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_build_wheels_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
pre-script: ""
env-script: packaging/windows/internal/vc_env_helper.bat
post-script: ""
smoke-test-script: ""
smoke-test-script: test/smoke_test.py
package-name: torchvision
- repository: pytorch/text
pre-script: ""
Expand Down