[BugFix] Minor fixes PPO / A2C examples #1591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vmoens
reviewed
Oct 2, 2023
There was a problem hiding this comment.
The tests are broken with
AttributeError: 'AtariEnv' object has no attribute 'append_transform'
this is because in PPO we don't put the env in a TransformedEnv.
Didn't we want to do this for DQN too?
Also, I was thinking: do we want to make this transform an "official" one? Would require tests and everything though.. Maybe we can leave it for later? Up to you!
Another point: Are we sure that this trick plays well with terminated?
Now we will have some "done" that are not synced with "terminated".
After #1581 this wil lbe an issue, that will require us to do:
loss.set_keys(done="end_of_life", terminated="end_of_life")(i think)
examples/ppo/utils_atari.py
Outdated
| if not is_test: | ||
| reader = default_info_dict_reader(["end_of_life"]) | ||
| env.set_info_dict_reader(reader) | ||
| env = TransformedEnv(env, EndOfLifeTransform()) |
There was a problem hiding this comment.
we can just append the transform here (after you put your env in the TransformedEnv)
examples/a2c/utils_atari.py
Outdated
| if not is_test: | ||
| reader = default_info_dict_reader(["end_of_life"]) | ||
| env.set_info_dict_reader(reader) | ||
| env = TransformedEnv(env, EndOfLifeTransform()) |
There was a problem hiding this comment.
we can just append the transform here
vmoens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some minor fixes in the PPO and A2C examples, related to the end-of-lives tranform.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!