-
Notifications
You must be signed in to change notification settings - Fork 412
[BugFix] Fix LazyStackedCompositeSpec
and introducing consolidate_spec
#1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
@vmoens for print of het dicts what about something like
|
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
LazyStackedCompositeSpec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Aside from the few comments I left, I noticed that the new classes are not part of the doc.
Signed-off-by: Matteo Bettini <[email protected]>
Co-authored-by: Vincent Moens <[email protected]>
Co-authored-by: Vincent Moens <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
LazyStackedCompositeSpec
LazyStackedCompositeSpec
and introducing consolidate_spec
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do the boxes that are unticked raising errors when called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do the boxes that are unticked raising errors when called?
i ll find out and fix if needed |
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
…spec` (pytorch#1392) Signed-off-by: Matteo Bettini <[email protected]> Co-authored-by: vmoens <[email protected]>
This PR will be a superset of #1365, which should be closed.
It tackles tasks from #969
Together with #1391 it becomes a superset of #1204 which should be eventually closed
It fixes #1343
Methods missing are due to time constraint and we can implement them in the future on a need basis
Fixes operations in lazy stack composite specs:
unsqueeze
squeeze
print
(it behaves like LazyStackedTd)__len__
__eq__
__ne__
project
type_check
__delitem__
__iter__
keys
__setitem__
update
is_in
unbind
Missing:
encode
Bonus, some operations in lazy stacked specs:
shape
stack only if same spec type, dtype and ndims
print
__len__
__eq__
squeeze
unsqueeze
unbind
Missing:
is_in
project
type_check
encode