Skip to content

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Jul 18, 2023

@vmoens @hyerra

This improves the test in #1204

Look at the spec of this env.

In my opinion it should cover all heterogenous use cases apart from composite actions, can you think of something I missed?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2023
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
@matteobettini matteobettini changed the title [Test] Heterogenous env [Test] Heterogeneous env Jul 18, 2023
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
@hyerra
Copy link
Contributor

hyerra commented Jul 18, 2023

Thanks, this looks really good for the heterogeneous part! One suggestion though, is it possible to have a test for where agents have a different number of observations? This is possible in Unity, for instance. For example, maybe agent 1 has both lidar and camera, but agent 2 only has lidar.

@matteobettini
Copy link
Contributor Author

Thanks, this looks really good for the heterogeneous part! One suggestion though, is it possible to have a test for where agents have a different number of observations? This is possible in Unity, for instance. For example, maybe agent 1 has both lidar and camera, but agent 2 only has lidar.

are you referring to the fact that the obs tensordicts have the same number of keys? would it cover your case if I remove the sonar from agent 2?

Signed-off-by: Matteo Bettini <[email protected]>
@hyerra
Copy link
Contributor

hyerra commented Jul 18, 2023

Yep, exactly, that case should cover it! I'm not sure if this case was what caused the bug in the StrikersVsGoalie game to fail. I didn't fully debug it just yet, but that was my initial guess.

Edit: Oh wait, actually on second thought, I think I understand now why the StrikersVsGoalie game failed. It wasn't because of the number of keys. I'll update the Unity PR to discuss this more there.

Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
@matteobettini matteobettini deleted the het_env_test branch July 27, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants