Skip to content

Conversation

@jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented Nov 19, 2024

Summary

Merge in pytorch/pytorch#140578 to fix label checker crashing during comment deletion

Test plan

Added main to pull_request and manually tested no lablel, topic: not user facing, and a few of the release notes: labels.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6953

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 4a4e5dd with merge base eae0b04 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2024
@jackzhxng jackzhxng force-pushed the jz/fix-label-checker branch from 5fb0341 to 77a9572 Compare November 19, 2024 06:24
@jackzhxng jackzhxng added topic: not user facing release notes: exir Changes to any dialects and passes on these dialects, such as memory planning and removed topic: not user facing labels Nov 19, 2024
@jackzhxng jackzhxng force-pushed the jz/fix-label-checker branch from 8b1c325 to 1440c88 Compare November 19, 2024 06:42
@jackzhxng jackzhxng added release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) release notes: exir Changes to any dialects and passes on these dialects, such as memory planning and removed release notes: exir Changes to any dialects and passes on these dialects, such as memory planning release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) labels Nov 19, 2024
@jackzhxng jackzhxng force-pushed the jz/fix-label-checker branch from fa5c0e8 to dd9fe34 Compare November 19, 2024 07:01
@jackzhxng jackzhxng added release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) and removed release notes: exir Changes to any dialects and passes on these dialects, such as memory planning labels Nov 19, 2024
@jackzhxng jackzhxng removed the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label Nov 19, 2024
@jackzhxng jackzhxng added release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) topic: not user facing and removed release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) labels Nov 19, 2024
@jackzhxng jackzhxng merged commit f477fd5 into main Nov 19, 2024
40 checks passed
@jackzhxng jackzhxng deleted the jz/fix-label-checker branch November 19, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants