Skip to content

Commit 77a9572

Browse files
committed
Label checker fix
1 parent eae0b04 commit 77a9572

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

.github/scripts/check_labels.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ def main() -> None:
4242
repo = GitRepo(get_git_repo_dir(), get_git_remote_name())
4343
org, project = repo.gh_owner_and_name()
4444
pr = GitHubPR(org, project, args.pr_num)
45+
print(f"repo: {repo}")
46+
print(f"org, project: {org}, {project}")
47+
print(f"pr: {pr}")
4548

4649
try:
4750
if not has_required_labels(pr):
@@ -50,11 +53,14 @@ def main() -> None:
5053
if args.exit_non_zero:
5154
sys.exit(1)
5255
else:
56+
print("pass")
5357
delete_all_label_err_comments(pr)
5458
except Exception as e:
59+
print("general exception")
5560
if args.exit_non_zero:
5661
sys.exit(1)
5762

63+
print("success")
5864
sys.exit(0)
5965

6066

.github/scripts/label_utils.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ def get_last_page_num_from_header(header: Any) -> int:
6464
@lru_cache
6565
def gh_get_labels(org: str, repo: str) -> List[str]:
6666
prefix = f"https://api.github.com/repos/{org}/{repo}/labels?per_page=100"
67+
print(f"prefix: {prefix}")
6768
header, info = request_for_labels(prefix + "&page=1")
6869
labels: List[str] = []
6970
update_labels(labels, info)
@@ -76,6 +77,8 @@ def gh_get_labels(org: str, repo: str) -> List[str]:
7677
_, info = request_for_labels(prefix + f"&page={page_number}")
7778
update_labels(labels, info)
7879

80+
print(f"all labels on gh: {labels}")
81+
7982
return labels
8083

8184

@@ -112,11 +115,15 @@ def get_release_notes_labels(org: str, repo: str) -> List[str]:
112115

113116

114117
def has_required_labels(pr: "GitHubPR") -> bool:
118+
print(f"pr: {pr}, pr.org: {pr.org}, pr.project: {pr.project}")
115119
pr_labels = pr.get_labels()
120+
print(f"pr_labels: {pr_labels}")
116121
# Check if PR is not user facing
117122
is_not_user_facing_pr = any(
118123
label.strip() == "topic: not user facing" for label in pr_labels
119124
)
125+
print(f"is_not_user_facing_pr: {is_not_user_facing_pr}")
126+
print(f"release note labels: {get_release_notes_labels(pr.org, pr.project)}")
120127
return is_not_user_facing_pr or any(
121128
label.strip() in get_release_notes_labels(pr.org, pr.project)
122129
for label in pr_labels

0 commit comments

Comments
 (0)