Skip to content

Refactor Init function arg #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Refactor Init function arg #6673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions runtime/executor/test/backend_integration_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class StubBackend final : public BackendInterface {
using InitFn = std::function<Result<DelegateHandle*>(
FreeableBuffer*,
ArrayRef<CompileSpec>,
MemoryAllocator*)>;
BackendInitContext&)>;
using ExecuteFn = std::function<Error(DelegateHandle*, EValue**)>;
using DestroyFn = std::function<void(DelegateHandle*)>;

Expand Down Expand Up @@ -83,8 +83,7 @@ class StubBackend final : public BackendInterface {
FreeableBuffer* processed,
ArrayRef<CompileSpec> compile_specs) const override {
if (init_fn_) {
return init_fn_.value()(
processed, compile_specs, context.get_runtime_allocator());
return init_fn_.value()(processed, compile_specs, context);
}
// Return a benign value otherwise.
return nullptr;
Expand Down Expand Up @@ -351,7 +350,7 @@ TEST_P(BackendIntegrationTest, FreeingProcessedBufferSucceeds) {
StubBackend::singleton().install_init(
[&](FreeableBuffer* processed,
ET_UNUSED ArrayRef<CompileSpec> compile_specs,
ET_UNUSED MemoryAllocator* runtime_allocator)
ET_UNUSED BackendInitContext& backend_init_context)
-> Result<DelegateHandle*> {
init_called = true;
processed_data = processed->data();
Expand Down Expand Up @@ -395,7 +394,7 @@ TEST_P(BackendIntegrationTest, EndToEndTestWithProcessedAsHandle) {
StubBackend::singleton().install_init(
[&](FreeableBuffer* processed,
ET_UNUSED ArrayRef<CompileSpec> compile_specs,
ET_UNUSED MemoryAllocator* runtime_allocator)
ET_UNUSED BackendInitContext& backend_init_context)
-> Result<DelegateHandle*> {
init_processed = processed;
return processed;
Expand Down Expand Up @@ -492,7 +491,7 @@ TEST_P(BackendIntegrationTest, SegmentInfoIsPassedIntoDataLoader) {
StubBackend::singleton().install_init(
[&](FreeableBuffer* processed,
ET_UNUSED ArrayRef<CompileSpec> compile_specs,
ET_UNUSED MemoryAllocator* runtime_allocator)
ET_UNUSED BackendInitContext& backend_init_context)
-> Result<DelegateHandle*> {
processed_data = processed->data();
processed->Free();
Expand Down Expand Up @@ -606,7 +605,7 @@ TEST_P(DelegateDataAlignmentTest, ExpectedDataAlignment) {
StubBackend::singleton().install_init(
[&](FreeableBuffer* processed,
ET_UNUSED ArrayRef<CompileSpec> compile_specs,
ET_UNUSED MemoryAllocator* runtime_allocator)
ET_UNUSED BackendInitContext& backend_init_context)
-> Result<DelegateHandle*> {
processed_data = processed->data();
return nullptr;
Expand Down
Loading