Refactor Init function arg #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into pytorch:main from cccclai:export-D65499276

Nov 6, 2024

Contributor

cccclai commented Nov 5, 2024

Summary:
The actual init function takes in backend init context instead of memory allocator directly. See

executorch/runtime/backend/interface.h

Lines 81 to 84 in 836d556

    
           ET_NODISCARD virtual Result<DelegateHandle*> init( 
        
               BackendInitContext& context, 
        
               FreeableBuffer* processed, 
        
               ArrayRef<CompileSpec> compile_specs) const = 0;

Update the signature in the test so it's easier to add test for exposing method name in next diff

Differential Revision: D65499276

pytorch-bot bot commented Nov 5, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6673

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit b79dcab with merge base 068f43c ():

NEW FAILURES - The following jobs have failed:

pull / test-binary-size-linux-gcc / linux-job (gh)
RuntimeError: Command docker exec -t 9aa46c317443ff2ec9dc5fb1f9925510e1a12240262032c574a72556dd860892 /exec failed with exit code 1
pull / unittest-arm / linux-job (gh)
RuntimeError: Command docker exec -t ed74b17cc0d6a7a8128fef4e5c76a181aaada23c0e926a550146f3bde2816853 /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Nov 5, 2024

This pull request was exported from Phabricator. Differential Revision: D65499276

facebook-github-bot added the fb-exported label

cccclai requested review from dbort and kimishpatel

November 5, 2024 21:42

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Refactor Init function arg (pytorch#6673)

39f3602

Summary:

The actual init function takes in backend init context instead of memory allocator directly. See https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h#L81-L84

Update the signature in the test so it's easier to add test for exposing method name in next diff

Differential Revision: D65499276

cccclai force-pushed the export-D65499276 branch from a7df18e to 39f3602 Compare

November 5, 2024 21:51

Contributor

facebook-github-bot commented Nov 5, 2024

This pull request was exported from Phabricator. Differential Revision: D65499276

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Refactor Init function arg (pytorch#6673)

85ec022

Summary:

The actual init function takes in backend init context instead of memory allocator directly. See https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h#L81-L84

Update the signature in the test so it's easier to add test for exposing method name in next diff

Differential Revision: D65499276

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Refactor Init function arg (pytorch#6673)

034bbf6

Summary:

The actual init function takes in backend init context instead of memory allocator directly. See https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h#L81-L84

Update the signature in the test so it's easier to add test for exposing method name in next diff

Reviewed By: dbort

Differential Revision: D65499276

cccclai force-pushed the export-D65499276 branch from 39f3602 to 034bbf6 Compare

November 6, 2024 00:06

Contributor

facebook-github-bot commented Nov 6, 2024

This pull request was exported from Phabricator. Differential Revision: D65499276

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Refactor Init function arg (pytorch#6673)

749a43e

Summary:

The actual init function takes in backend init context instead of memory allocator directly. See https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h#L81-L84

Update the signature in the test so it's easier to add test for exposing method name in next diff

Reviewed By: dbort

Differential Revision: D65499276

iseeyuan approved these changes

View reviewed changes

Contributor

iseeyuan left a comment

LGTM

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Refactor Init function arg (pytorch#6673)

0d9114e

Summary:

The actual init function takes in backend init context instead of memory allocator directly. See https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h#L81-L84

Update the signature in the test so it's easier to add test for exposing method name in next diff

Reviewed By: iseeyuan, dbort

Differential Revision: D65499276

cccclai force-pushed the export-D65499276 branch from 034bbf6 to 0d9114e Compare

November 6, 2024 01:56

Contributor

facebook-github-bot commented Nov 6, 2024

This pull request was exported from Phabricator. Differential Revision: D65499276

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Refactor Init function arg (pytorch#6673)

4dac102

Summary:

The actual init function takes in backend init context instead of memory allocator directly. See https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h#L81-L84

Update the signature in the test so it's easier to add test for exposing method name in next diff

Reviewed By: iseeyuan, dbort

Differential Revision: D65499276


          Refactor Init function arg (pytorch#6673)

b79dcab

Summary:

The actual init function takes in backend init context instead of memory allocator directly. See https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h#L81-L84

Update the signature in the test so it's easier to add test for exposing method name in next diff

Reviewed By: iseeyuan, dbort

Differential Revision: D65499276

cccclai force-pushed the export-D65499276 branch from 0d9114e to b79dcab Compare

November 6, 2024 02:09

Contributor

facebook-github-bot commented Nov 6, 2024

This pull request was exported from Phabricator. Differential Revision: D65499276

facebook-github-bot merged commit b4c6fe1 into pytorch:main

38 of 41 checks passed

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Update backend execute args in test

1aadcc0

Summary:
Similar to pytorch#6673, we update the execute args the same as the actual interface

https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h?fbclid=IwZXh0bgNhZW0CMTEAAR37pGH_HbSLZTCatfjnXGr_CLc8Th-SpoS4CeKb00z1ngNBJd6OdniK19Q_aem_xk7M6diLe_FAsplz8BZRQg#L96-L99

Differential Revision: D65585157

cccclai mentioned this pull request

Update backend execute args in test #6708

Merged

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Update backend execute args in test (pytorch#6708)

cc6cdba

Summary:

Similar to pytorch#6673, we update the execute args the same as the actual interface

https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h?fbclid=IwZXh0bgNhZW0CMTEAAR37pGH_HbSLZTCatfjnXGr_CLc8Th-SpoS4CeKb00z1ngNBJd6OdniK19Q_aem_xk7M6diLe_FAsplz8BZRQg#L96-L99

Reviewed By: kirklandsign

Differential Revision: D65585157

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Update backend execute args in test (pytorch#6708)

6a43d44

Summary:

Similar to pytorch#6673, we update the execute args the same as the actual interface

https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h?fbclid=IwZXh0bgNhZW0CMTEAAR37pGH_HbSLZTCatfjnXGr_CLc8Th-SpoS4CeKb00z1ngNBJd6OdniK19Q_aem_xk7M6diLe_FAsplz8BZRQg#L96-L99

Reviewed By: kirklandsign

Differential Revision: D65585157

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Update backend execute args in test (pytorch#6708)

cfcf13b

Summary:

Similar to pytorch#6673, we update the execute args the same as the actual interface

https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h?fbclid=IwZXh0bgNhZW0CMTEAAR37pGH_HbSLZTCatfjnXGr_CLc8Th-SpoS4CeKb00z1ngNBJd6OdniK19Q_aem_xk7M6diLe_FAsplz8BZRQg#L96-L99

Reviewed By: kirklandsign

Differential Revision: D65585157

cccclai added a commit to cccclai/executorch-1 that referenced this pull request


          Update backend execute args in test (pytorch#6708)

114929e

Summary:

Similar to pytorch#6673, we update the execute args the same as the actual interface

https://github.com/pytorch/executorch/blob/836d5561a61877507b6d5891485725996bb6b32c/runtime/backend/interface.h?fbclid=IwZXh0bgNhZW0CMTEAAR37pGH_HbSLZTCatfjnXGr_CLc8Th-SpoS4CeKb00z1ngNBJd6OdniK19Q_aem_xk7M6diLe_FAsplz8BZRQg#L96-L99

bypass-github-export-checks

Reviewed By: kirklandsign

Differential Revision: D65585157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported