-
Notifications
You must be signed in to change notification settings - Fork 542
Optim-wip: Add Class Activation Atlas Tutorial Notebook #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optim-wip: Add Class Activation Atlas Tutorial Notebook #850
Conversation
@ProGamerGov, sorry for getting back late to this PR. I've just had a quick look and it looks like some of the things that we showcase here we already have in the tutorial that we've already merged: For example |
@NarineK I think that we can probably just remove the 'Activation Atlas Shape' section as it's covered in the main atlas tutorial, and it's not particularly important for the class atlas tutorial. I'll also change the first 'Dimensionality Reduction For Coordinate Grid Creation' section's text to be more simplified like in part 2 of the tutorial:
I tried to structure the class atlas tutorial so that it was similar to the first atlas tutorial, to make it easier to understand. Due to the similarities between both atlas tutorials, there are some sections of text that are repeated across both tutorials. Some repetition was unavoidable and it helps individuals refresh their knowledge on the subject. |
@ProGamerGov, if it is text description, similarity it is fine. If those are functions that are shared between 2 tutorials you can put them in a python file under:
|
To avoid duplicates you can also refer to the other notebook from this notebook. So that the users can check out the other one first. |
@NarineK So actually other than the two items that you mentioned, I don't think there's any other duplication of the other atlas tutorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ProGamerGov, thank you for the PR and sorry for the delay reviewing it.
Here are some minor comments:
- nit: multi-class ? (seen at several places)
- The class-specific version that only focuses on the specified class. -> Maybe this bullet point can come first ?
- So, there are two versions:
class-specific
andclass-specific with context
? What is the context in that case ? Maybe you can describe it a little bit ? - In the section
Dimensionality Reduction For Coordinate Grid Creation
do you mind adding a description on how to interpret sample activation atlas ? - we will used Captum.optim's -> we will use ... ?
- Wouldn't we get duplicate indices here if some indices in
class_indices
overlap withtop_positive_class_indices
? - Sample Whitening -> Do you mind moving this closer to the section where it is used ?
- In the bottom of
Rendering The Single Class Activation Atlas Visualizations
section maybe you can write a little bit interpretation of the visualized class activation atlas. E.g.On the atlas we recognize high level concepts associated to scuba diver such as ...
? - For the
xy coordinate grid
do you mind labelling the axes ?
|
Thank you, @ProGamerGov! |
* TSNE -> t-SNE * Added axes labels to second xy graph.
@NarineK Okay, I've added the labels to the second plotted graph! |
Thank you, @ProGamerGov! Merging ... |
This PR simplifies the commit history of: #730
This PR adds the
ClassActivationAtlas_OptimViz.ipynb
tutorial notebook, which is the final activation atlas tutorial. I've also updated the class atlas notebook based on the feedback for the main atlas tutorial.