Skip to content

Add OPUS support to 0.6 release #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2020
Merged

Add OPUS support to 0.6 release #763

merged 2 commits into from
Jul 6, 2020

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Jul 1, 2020 •
edited
Loading

Cherry-picking #753 and #755 for 0.6 release.

@mthrok
Use cmake for third party (pytorch#753)
9c4b4f2 
* Use cmake for third party

* Apply patch to libmad

* Update gitignore

* Update docker test image
@mthrok mthrok changed the title Add opus support Add OPUS support to 0.6 release Jul 1, 2020
@mthrok mthrok force-pushed the add-opus-support branch from 88f554b to a5a52c4 Compare July 2, 2020 00:01
@codecov
Copy link

codecov bot commented Jul 2, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release/0.6@ee98d07). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/0.6     #763   +/-   ##
==============================================
  Coverage               ?   88.99%           
==============================================
  Files                  ?       32           
  Lines                  ?     2527           
  Branches               ?        0           
==============================================
  Hits                   ?     2249           
  Misses                 ?      278           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee98d07...a5a52c4. Read the comment docs.

@mthrok mthrok marked this pull request as ready for review July 2, 2020 03:39
@mthrok mthrok requested a review from seemethere July 2, 2020 03:39
@vincentqb
Copy link
Contributor

vincentqb commented Jul 2, 2020

@seemethere -- do you have a link to the current planned dates for the final branch cuts for the next release for the domains?

@seemethere
Copy link
Member

seemethere commented Jul 2, 2020

@seemethere -- do you have a link to the current planned dates for the final branch cuts for the next release for the domains?

We're expecting a final RC for PyTorch by July 7th, so I'd expect domains to follow in the couple of days after that

@vincentqb
Copy link
Contributor

vincentqb commented Jul 2, 2020

@seemethere -- do you have a link to the current planned dates for the final branch cuts for the next release for the domains?

We're expecting a final RC for PyTorch by July 7th, so I'd expect domains to follow in the couple of days after that

At that point, it would make sense to simply re-cut the branch from master. Thoughts?

@mthrok mthrok merged commit 56aa954 into pytorch:release/0.6 Jul 6, 2020
@mthrok mthrok deleted the add-opus-support branch July 6, 2020 15:26
@mthrok
Copy link
Contributor Author

mthrok commented Jul 6, 2020

thanks!

mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
Merge pull request pytorch#763 from mrshenli/ddp
e49fa58 
Adding DDP example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mthrok @vincentqb @seemethere