Skip to content

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Nov 3, 2021

This commit ports Audio I/O tutorials from tutorials repo.

The tutorials are placed under the new Getting Started section, and the index page is updated a bit.

Current
https://pytorch.org/audio/main/index.html
Screen Shot 2021-11-05 at 12 58 41

After
https://426860-90321822-gh.circle-artifacts.com/0/docs/index.html
Screen Shot 2021-11-05 at 12 41 46 PM

Note: I cannot import boto3 on M1 Mac. I think it's an issue with the binary signature (killed 9). So the doc build process will not work on M1 Mac.

@mthrok mthrok mentioned this pull request Nov 3, 2021
10 tasks
@mthrok mthrok force-pushed the sg-audio branch 5 times, most recently from a398112 to 17f665d Compare November 4, 2021 01:48
@mthrok mthrok mentioned this pull request Nov 4, 2021
@mthrok mthrok force-pushed the sg-audio branch 4 times, most recently from eed8011 to b06bfe6 Compare November 5, 2021 15:47
@mthrok mthrok marked this pull request as ready for review November 5, 2021 16:59
Copy link
Contributor

@hwangjeff hwangjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going forward, would we have to manually sync tutorials between here and the main tutorials repo?

@mthrok
Copy link
Contributor Author

mthrok commented Nov 5, 2021

going forward, would we have to manually sync tutorials between here and the main tutorials repo?

Yes, so far. Or we can come up with some automation, or get rid of the tutorials on tutorials repo.

@mthrok
Copy link
Contributor Author

mthrok commented Nov 5, 2021

Let's see how these goes...

pytorch/tutorials#1740
pytorch/tutorials#1741

@mthrok mthrok merged commit 8f06198 into pytorch:main Nov 5, 2021
@mthrok mthrok deleted the sg-audio branch November 5, 2021 19:01
mthrok added a commit to mthrok/audio that referenced this pull request Dec 3, 2021
mthrok added a commit to mthrok/audio that referenced this pull request Dec 3, 2021
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants