-
Notifications
You must be signed in to change notification settings - Fork 743
Add Sphinx-gallery to doc #1967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| .. py:module:: torchaudio.functional | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the function of adding it for sphinx-gallery?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows to refer to the module as a whole from examples, like :py:mod:torchaudio.functional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Looks nice.
examples/gallery/wav2vec2/speech_recognition_pipeline_tutorial.py
Outdated
Show resolved
Hide resolved
examples/gallery/wav2vec2/speech_recognition_pipeline_tutorial.py
Outdated
Show resolved
Hide resolved
examples/gallery/wav2vec2/speech_recognition_pipeline_tutorial.py
Outdated
Show resolved
Hide resolved
|
The tutorial has the same rendering issue for the last plot: https://pytorch.org/tutorials/intermediate/forced_alignment_with_torchaudio_tutorial.html |
@nateanl Yeah, once this one is merged, I will make a PR in tutorials repo to port the fix. |
5bd1360 to
85f476c
Compare
|
Overall the changes/rendering looks good, but I was originally under the assumption that the gallery was only for tutorials that aren't also in the pytorch.org tutorials section (either because they use unreleased features or if for some reason we do not think it belongs in pytorch.org). What is the reason for including the same tutorials in both the gallery and website? Updating existing tutorials would then require twice the amount of work to ensure that they are synced. On another note, I realized the W2V2 speech recognition tutorial link for pytorch.org seems broken, at least on my end https://pytorch.org/tutorials/intermediate_source/speech_recognition_pipeline_tutorial.html |
There are couple of advantages of maintaining the tutorial here as well.
So in short, we can consider the tutorials in our repo as a staging place with nightly binary packages. |
Where did you get this? The tutorial is at |
|
https://pytorch.org/tutorials/ and click the asr demo. I got the same 404 as @carolineechen. |
|
@mthrok ok, that makes sense to me. In that case we just need to make sure to remember to add to the release milestone or create a tutorials label to keep track of the necessary tutorial updates prior to release. and yea, the tutorial link you commented works, but clicking through pytorch.org/tutorials -> audio -> ASR tutorial redirects to the broken link I commented |
|
@carolineechen @nateanl Okay, the fix for the tutorial link pytorch/tutorials#1738 |
|
Thanks! |
Summary: title Reviewed By: mthrok Differential Revision: D32172311 fbshipit-source-id: b6de6faa2f66e50ab47a2fba3c46674a828d6d0a
Add Sphinx-gallery to documentation so that we can maintain the notebook for the main branch, and copy it over to tutorial repo at new releases.
https://419306-90321822-gh.circle-artifacts.com/0/docs/index.html
Basic Goal
Stretch Goal (separate PRs)
Run in Google Colab[src] (might be better to update PyTorch-sphinx-theme) (Add Colab/Download/Github link similar to tutorials #1969)pytorch/tutorials)