Fix the int4 table batched embedding benchmark with mixed dim #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix the bench with "--mixed" dimension as reported by xcliang in https://www.internalfb.com/diff/D28248236 (pytorch@0fe80ee014b936733278a77d0a24c9fe9a431c31)?dst_version_fbid=834500627143449&transaction_fbid=331571331658562 Differential Revision: D28466825 fbshipit-source-id: a343a3d629c8fc751fc228321f5f43ec28065f99
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28466825 |
Contributor
|
This pull request has been merged in c48ba9b. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#609 X-link: pytorch#3527 Masking is needed to avoid out-of-bound reference for the last row. This fixes an illegal access error. Reviewed By: jianyuh Differential Revision: D67588103 fbshipit-source-id: 7ea9203bea8212e7ab340891b1d49d7c9eb85d39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix the bench with "--mixed" dimension as reported by xcliang in https://www.internalfb.com/diff/D28248236 (0fe80ee014b936733278a77d0a24c9fe9a431c31)?dst_version_fbid=834500627143449&transaction_fbid=331571331658562
Differential Revision: D28466825