Fix out-of-bound load in row scaling #3527
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Masking is needed to avoid out-of-bound reference for the last row. This fixes an illegal access error. Differential Revision: D67588103
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67588103 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
htyu
added a commit
to htyu/FBGEMM
that referenced
this pull request
Dec 27, 2024
Summary: X-link: facebookresearch/FBGEMM#609 Masking is needed to avoid out-of-bound reference for the last row. This fixes an illegal access error. Differential Revision: D67588103
htyu
added a commit
to htyu/FBGEMM
that referenced
this pull request
Dec 28, 2024
Summary: X-link: facebookresearch/FBGEMM#609 Masking is needed to avoid out-of-bound reference for the last row. This fixes an illegal access error. Reviewed By: jianyuh Differential Revision: D67588103
Contributor
|
This pull request has been merged in 0c93fd0. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#609 X-link: pytorch#3527 Masking is needed to avoid out-of-bound reference for the last row. This fixes an illegal access error. Reviewed By: jianyuh Differential Revision: D67588103 fbshipit-source-id: 7ea9203bea8212e7ab340891b1d49d7c9eb85d39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Masking is needed to avoid out-of-bound reference for the last row. This fixes an illegal access error.
Differential Revision: D67588103