Use protocol for print() file argument #2848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use object instead of Any for values list
Member
|
The test failure looks like it's because of the |
JelleZijlstra
approved these changes
Mar 11, 2019
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good apart from the selftest failure. This is documented in https://docs.python.org/3/library/functions.html#print.
srittau
added a commit
to srittau/mypy
that referenced
this pull request
Mar 11, 2019
This removes coupling to the exact type annotation of print() in typeshed. Cf. python/typeshed#2848
This was referenced Mar 11, 2019
JelleZijlstra
pushed a commit
to python/mypy
that referenced
this pull request
Mar 12, 2019
This removes coupling to the exact type annotation of print() in typeshed. Cf. python/typeshed#2848
Member
|
Going to close and re-open to re-trigger CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use object instead of Any for values list