[traceback] Expose print_list method in traceback for python3. #2837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add print_list to traceback based on https://github.com/python/cpython/blob/master/Lib/traceback.py#L19.
srittau
requested changes
Mar 10, 2019
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thank you for the pull request. Notes below.
stdlib/2and3/traceback.pyi
Outdated
| def extract_stack(f: Optional[FrameType] = ..., | ||
| limit: Optional[int] = ...) -> StackSummary: ... | ||
| def format_list(extracted_list: List[FrameSummary]) -> List[str]: ... | ||
| def print_list(extracted_list: List[FrameSummary], file: Optional[IO[str]] = ...) -> None: ... |
Collaborator
There was a problem hiding this comment.
- This should be marked with
# undocumented. - While
StackSummary.from_list()is also annotated as expecting a list, expecting anIterable[FrameSummary]should suffice. print()is annotated as expecting anIO[str]. We are trying to move away from usingIOfor argument types. Could you defined a protocol like this and use it for the file argument:
class _Writable(Protocol):
def write(self, s: str) -> Any:
passI will send a separate PR for print().
Contributor
Author
There was a problem hiding this comment.
Will do. Thanks for the commends and suggestions!
Contributor
Author
There was a problem hiding this comment.
Looks like all tests have finished but status is still pending...
The patch contains two minor fixes: 1) Mark the method as '# undocumented' 2) Change 'file' argument type from IO to _Writable
srittau
approved these changes
Mar 11, 2019
Collaborator
|
I don't know why it's still showing as pending, but since all tests are green, I'm meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add print_list to traceback based on https://github.com/python/cpython/blob/master/Lib/traceback.py#L19.