tests: re-enable py38, skip with missing/broken lxml #6917
Conversation
blueyed
force-pushed
the
lxml-optional-tests
branch
from
cbd088b to
b0dc4bd
Compare
|
Now it appears to fail because of py38 itself: https://travis-ci.org/python/mypy/jobs/540209205#L357 |
|
Mostly/only:
But still at least one related to lxml:
|
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
I think it would be best not to install lxml on 3.8 for the time being and add it back latter, so we can keep running some tests.
Sounds good - just noticed that it was pinned to an older version, trying an upgrade there first.
👍 reverted |
blueyed
force-pushed
the
lxml-optional-tests
branch
from
fcee3cd to
06da1cc
Compare
|
Ok, also broken with lxml==4.3.3. |
|
Needs more skipping... What to do about the following?
|
|
FWIW, locally typed-ast fails to build for me (current cpython master), so that might be a next issue here then maybe also. Shouldn't be used according to https://github.com/python/typed_ast#python-38 anyway?! |
setup.py
Outdated
| cmdclass=cmdclass, | ||
| # When changing this, also update test-requirements.txt. | ||
| install_requires=['typed-ast >= 1.3.5, < 1.4.0; python_version < "3.8"', | ||
| install_requires=['typed-ast >= 1.3.5, < 1.4.0', |
There was a problem hiding this comment.
I wonder if that does not make sense though in general?
Even when assuming that it gets used with --python-version / for versions before py38, it could still be an optional dependency then, being checked during runtime?!
|
Looks like you had a bad rebase or something? |
Confused by running only a single job? (see the TEMP commits) |
|
python/typed_ast#119 should fix compilation on 3.8, then we'll do a typed-ast release. No way around requiring typed_ast, I think. (We could make python2 support optional but I don't like that idea.) |
|
@msullivan What should we do about the DeprecationWarnings? |
This reverts commit 3c64bca.
blueyed
force-pushed
the
lxml-optional-tests
branch
from
551ae6b to
02d2d27
Compare
|
we've reenabled 3.8 without trouble a while ago |
3 participants
No description provided.