Disable travis builds on 3.8 #6912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new argument to PyCode_New means that lxml doesn't work on 3.8 right now, so we're out of business until there's a new lxml release that does. (If that is taking too long, we can disable the tests that want lxml.) There are also some other minor issues: we fail some tests with `DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead` while running some of the eval tests.
ilevkivskyi
approved these changes
May 29, 2019
emmatyping
approved these changes
May 29, 2019
Contributor
|
How about skipping those tests when lxml is not installed, and making it an optional requirement for tests in general? |
blueyed
added a commit
to blueyed/mypy
that referenced
this pull request
Jun 1, 2019
This reverts commit 3c64bca.
blueyed
added a commit
to blueyed/mypy
that referenced
this pull request
Jun 1, 2019
blueyed
added a commit
to blueyed/mypy
that referenced
this pull request
Jun 1, 2019
blueyed
added a commit
to blueyed/mypy
that referenced
this pull request
Jun 3, 2019
This reverts commit 3c64bca.
blueyed
added a commit
to blueyed/mypy
that referenced
this pull request
Jun 3, 2019
Collaborator
This is a good idea. We just need to be careful to run at least some lxml tests in CI, and we probably need to run them on all major platforms (but not every platform/Python version combination probably). |
blueyed
added a commit
to blueyed/mypy
that referenced
this pull request
Jun 8, 2019
This reverts commit 3c64bca.
blueyed
added a commit
to blueyed/mypy
that referenced
this pull request
Jun 8, 2019
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
The new argument to PyCode_New means that lxml doesn't work on 3.8 right now, so we're out of business until there's a new lxml release that does. (If that is taking too long, we can disable the tests that want lxml.) There are also some other minor issues: we fail some tests with `DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead` while running some of the eval tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new argument to PyCode_New means that lxml doesn't work on 3.8
right now, so we're out of business until there's a new lxml release
that does. (If that is taking too long, we can disable the tests that
want lxml.)
There are also some other minor issues: we fail some tests with
DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" insteadwhile running some of the eval tests.