Move analysis of function signature to the first phase #5461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Aug 13, 2018
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
This seems totally plausible, but I am not very familiar with this part of semantic analysis and so if you are nervous about the change you might want to wait for Jukka.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5454
This fixes few similar overload crash scenarios.
The idea is quite simple: previously during first phase of function analysis we only set the full name and added it to locals, while during the second phase we analysed the signature and the function body. This however doesn't work with overloads, since we want to collect all item types into a single
Overloaded(...). What I propose is to just move analysis of signature and the initialisers to the first phase. IMO this is more logical (we just want to postpone the bodies), and is more close to runtime semantics (especially the initialisers that are evaluated immediately during function definition).