Overloaded functions at nested scopes are not analyzed, causing crashes

[ilevkivskyi]

Consider this simple example that crashes:

from typing import overload

def f() -> None:
    @overload
    def g(x: str) -> str: ...
    @overload
    def g(x: int) -> int: ...
    def g(x):
        pass

    g(str())

Adding a reveal_type(g) shows that overload variants are not analyzed at all, it shows:

Revealed type is 'Overload(def (x: str?) -> str?, def (x: int?) -> int?)'

[ilevkivskyi]

OK, the root of the problem is that there is two-phase function semantic analysis (to support things like testMutuallyRecursiveNestedFunctions) and it interferes badly with semantic analysis of overloads. There are two ways now:

• Just fix the crash (this is simple)
• Fix the crash right way (i.e. supporting mutual recursion for overloaded functions)

I will try to go the second way, but if it will be too hard, then I will make a simple fix.

[ilevkivskyi]

OK, it looks like like I have a simple proper fix.