Skip to content

gh-89928: Fix integer conversion of device numbers. #31794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 4, 2024
Merged

gh-89928: Fix integer conversion of device numbers. #31794

merged 12 commits into from
Jun 4, 2024

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 10, 2022 •
edited by bedevere-app bot
Loading

Fix os.major(), os.minor() and os.makedev().
Support device numbers larger than 2**63-1.
Support non-existent device number (NODEV).

https://bugs.python.org/issue45767

@serhiy-storchaka
bpo-45767: Fix integer conversion of device numbers.
18ee1e9 
Fix os.major(), os.minor() and os.makedev().
Support device numbers larger than 2**63-1.
Support non-existent device number (NODEV).
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.9 needs backport to 3.10 only security fixes labels Mar 10, 2022
@serhiy-storchaka serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 10, 2022
@bedevere-bot
Copy link

bedevere-bot commented Mar 10, 2022

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit c2d082b 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 10, 2022
@ambv
Copy link
Contributor

ambv commented May 17, 2022

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.11 only security fixes label May 20, 2022
iritkatriel
iritkatriel previously requested changes Nov 27, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

bedevere-bot commented Nov 27, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@hugovk hugovk removed the needs backport to 3.10 only security fixes label Apr 7, 2023
@serhiy-storchaka serhiy-storchaka mentioned this pull request Dec 14, 2023
Closed
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Dec 17, 2023

!buildbot freebsd

@bedevere-bot
Copy link

bedevere-bot commented Dec 17, 2023

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 17c02dc 🤖

The command will test the builders whose names match following regular expression: freebsd

The builders matched are:

  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR
  • AMD64 FreeBSD15 PR

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Dec 17, 2023

I have made the requested changes; please review again.

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only security fixes label Dec 28, 2023
vstinner
vstinner approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update.

@vstinner
Copy link
Member

vstinner commented Jun 2, 2024

@serhiy-storchaka: Do you want to merge this PR?

serhiy-storchaka
serhiy-storchaka commented Jun 3, 2024
View reviewed changes
Lib/test/test_posix.py
Comment on lines +728 to +729
if sys.platform == 'linux':
NODEV = -1
Copy link
Member Author

@serhiy-storchaka serhiy-storchaka May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to expose posix.NODEV, but this is a different issue.

Copy link

@kraj kraj Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, musl is another C library implementation on Linux ( like glibc ) which does not provide NODEV, so relying on platform to provide this definition may not be true always.

@serhiy-storchaka serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 3, 2024
@bedevere-bot
Copy link

bedevere-bot commented Jun 3, 2024

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 97e71d3 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 3, 2024
@serhiy-storchaka serhiy-storchaka merged commit 7111d96 into python:main Jun 4, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Jun 4, 2024

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the long-from-dev_t branch June 4, 2024 16:36
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2024
@serhiy-storchaka @miss-islington
pythongh-89928: Fix integer conversion of device numbers (pythonGH-31794
ee7efc3 
)

Fix os.major(), os.minor() and os.makedev().
Support device numbers larger than 2**63-1.
Support non-existent device number (NODEV).
(cherry picked from commit 7111d96)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington-app
Copy link

miss-islington-app bot commented Jun 4, 2024

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7111d9605f9db7aa0b095bb8ece7ccc0b8115c3f 3.12

@bedevere-app
Copy link

bedevere-app bot commented Jun 4, 2024

GH-120053 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 4, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 4, 2024
@serhiy-storchaka
[3.12] pythongh-89928: Fix integer conversion of device numbers (pyth…
4a81820 
…onGH-31794)

Fix os.major(), os.minor() and os.makedev().
Support device numbers larger than 2**63-1.
Support non-existent device number (NODEV).
(cherry picked from commit 7111d96)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 4, 2024

GH-120054 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 4, 2024
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jun 4, 2024
Closed
@vstinner
Copy link
Member

vstinner commented Jun 4, 2024

Thanks for the fix @serhiy-storchaka!

serhiy-storchaka added a commit that referenced this pull request Jun 4, 2024
@serhiy-storchaka
[3.12] gh-89928: Fix integer conversion of device numbers (GH-31794) (G…
f98ec75 
…H-120054)

Fix os.major(), os.minor() and os.makedev().
Support device numbers larger than 2**63-1.
Support non-existent device number (NODEV).
(cherry picked from commit 7111d96)
serhiy-storchaka added a commit that referenced this pull request Jun 4, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-89928: Fix integer conversion of device numbers (GH-31794) (G…
2acbdc2 
…H-120053)

Fix os.major(), os.minor() and os.makedev().
Support device numbers larger than 2**63-1.
Support non-existent device number (NODEV).
(cherry picked from commit 7111d96)

Co-authored-by: Serhiy Storchaka <[email protected]>
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@serhiy-storchaka @barneygale
pythongh-89928: Fix integer conversion of device numbers (pythonGH-31794
234a5df 
)

Fix os.major(), os.minor() and os.makedev().
Support device numbers larger than 2**63-1.
Support non-existent device number (NODEV).
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@serhiy-storchaka @noahbkim
pythongh-89928: Fix integer conversion of device numbers (pythonGH-31794
b209b9a 
)

Fix os.major(), os.minor() and os.makedev().
Support device numbers larger than 2**63-1.
Support non-existent device number (NODEV).
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-89928: Fix integer conversion of device numbers (pythonGH-31794
7dd6d8d 
)

Fix os.major(), os.minor() and os.makedev().
Support device numbers larger than 2**63-1.
Support non-existent device number (NODEV).
@kraj kraj mentioned this pull request Sep 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@iritkatriel iritkatriel iritkatriel left review comments

+1 more reviewer

@kraj kraj kraj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@serhiy-storchaka serhiy-storchaka

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@serhiy-storchaka @bedevere-bot @ambv @vstinner @kraj @iritkatriel @hugovk @the-knights-who-say-ni @ezio-melotti