Skip to content

gh-89928: consume dev_t with PyLong_FromUnsignedLongLong #29494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-89928: consume dev_t with PyLong_FromUnsignedLongLong #29494

wants to merge 1 commit into from

Conversation

@AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented Nov 9, 2021 •
edited by bedevere-app bot
Loading

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 10, 2021
@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Jan 20, 2022

Can you add a news entry ? https://blurb-it.herokuapp.com/

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Jan 20, 2022 •
edited
Loading

Can you add a news entry ? https://blurb-it.herokuapp.com/

Sure, done. Also added GH pull request number to summary and rebased.

@MaxwellDupre
Copy link
Contributor

MaxwellDupre commented Mar 1, 2022

I dont see the following:
#if defined(__FreeBSD__) #define DEVICE_MAJORMINOR_T int #else #define DEVICE_MAJORMINOR_T unsigned int #endif
In your Files changed, please explain?

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Mar 1, 2022

I dont see the following:

Because it's not there, obviously. This PR only addresses one aspect of the problem.

MaxwellDupre
MaxwellDupre approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@erlend-aasland erlend-aasland changed the title bpo-45767: consume dev_t with PyLong_FromUnsignedLongLong gh-89928: consume dev_t with PyLong_FromUnsignedLongLong Jan 5, 2024
@AMDmi3 AMDmi3 mannequin mentioned this pull request Mar 28, 2024
Closed
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jun 4, 2024

Thank you for your contribution, but more complex #31794 was merged instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AMDmi3 @kumaraditya303 @MaxwellDupre @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot