Skip to content

GH-95952: Require setting HOSTRUNNER when cross compiling for WASI #138203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2025
Merged

GH-95952: Require setting HOSTRUNNER when cross compiling for WASI #138203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e47712c
GH-95952: Require setting `HOSTRUNNER` when cross compiling for WASI
brettcannon Aug 27, 2025
6949eee
Add a news entry
brettcannon Aug 27, 2025
d9a7927
Use a hyphen
brettcannon Aug 27, 2025
98d2b07
Merge branch 'main' into 95952-require-hostrunner
brettcannon Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Build/2025-08-27-11-32-02.gh-issue-95952.KSymc7.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
When cross-compiling for WASI, require that the HOSTRUNNER environment
variable be explicitly set.

This was needed as macOS lacks the appropriate CLI tools to set a reasonable
default.
6 changes: 4 additions & 2 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1636,10 +1636,9 @@ then
HOSTRUNNER="$NODE"
AS_VAR_IF([host_cpu], [wasm64], [AS_VAR_APPEND([HOSTRUNNER], [" --experimental-wasm-memory64"])])
],
dnl TODO: support other WASI runtimes
dnl wasmtime starts the process with "/" as CWD. For OOT builds add the
dnl directory containing _sysconfigdata to PYTHONPATH.
[WASI], [HOSTRUNNER='wasmtime run --wasm max-wasm-stack=16777216 --wasi preview2=n --env PYTHONPATH=/$(shell realpath --relative-to $(abs_srcdir) $(abs_builddir))/$(shell cat pybuilddir.txt):/Lib --dir $(srcdir)::/'],
[WASI], [
AC_MSG_ERROR([HOSTRUNNER must be set when cross-compiling to WASI])
],
[HOSTRUNNER='']
)
fi
Expand Down
Loading