Skip to content

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Aug 27, 2025

macOS by default doesn't have the requisite CLI tools to make a default value easy. Plus Tools/wasm/wasi takes care of setting HOSTRUNNER.

… WASI

macOS by default doesn't have the requisite CLI tools to make a default value easy. Plus Tools/wasm/wasi takes care of setting HOSTRUNNER.
@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit d9a7927 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138203%2Fmerge

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@brettcannon brettcannon marked this pull request as draft August 27, 2025 18:47
@brettcannon brettcannon marked this pull request as ready for review August 27, 2025 18:48
@brettcannon brettcannon marked this pull request as draft August 27, 2025 19:06
@brettcannon
Copy link
Member Author

Converting to draft while I think about what to do with the failing buildbots (they are structured for 3.11 and 3.12, so not critical for PR checks).

brettcannon added a commit to brettcannon/buildmaster-config that referenced this pull request Aug 27, 2025
It's primarily for testing 3.11 and 3.12 which is tier 3 only for WASI. Trying to keep it working is a perpetual issue and prevents python/cpython#138203 from landing.
@brettcannon
Copy link
Member Author

python/buildmaster-config#623 will turn off the non-debug PR builder. Once this lands I will convert the PR to being ready.

@brettcannon brettcannon marked this pull request as ready for review August 28, 2025 18:29
@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit d9a7927 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138203%2Fmerge

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@brettcannon brettcannon self-assigned this Aug 28, 2025
@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit 98d2b07 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138203%2Fmerge

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@zware
Copy link
Member

zware commented Aug 28, 2025

In spite of the message, only the expected one seems to have run. Likely due to my manually doing a reconfig rather than letting the regular update process do a full restart.

@brettcannon
Copy link
Member Author

In spite of the message, only the expected one seems to have run

Yeah, I double-checked with a branch update and that seems to be the case.

@brettcannon
Copy link
Member Author

I'll give the typical configure.ac reviewers some time to review this before merging.

@brettcannon brettcannon added build The build process and cross-build 3.15 new features, bugs and security fixes labels Aug 28, 2025
@brettcannon brettcannon merged commit bde1291 into python:main Sep 5, 2025
46 checks passed
@brettcannon brettcannon deleted the 95952-require-hostrunner branch September 5, 2025 22:48
@brettcannon
Copy link
Member Author

It's been a week, no one spoke up, and it's early in the life of 3.15 such that if I did something wrong we can undo it easily enough.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.x (tier-1) has failed when building commit bde1291.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1241/builds/6594) and take a look at the build logs.
  4. Check if the failure is related to this commit (bde1291) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1241/builds/6594

Failed tests:

  • test_launcher

Failed subtests:

  • tearDownClass - test.test_launcher.TestLauncher
  • test_search_major_2 - test.test_launcher.TestLauncher.test_search_major_2
  • test_py_handle_64_in_ini - test.test_launcher.TestLauncher.test_py_handle_64_in_ini
  • test_virtualenv_with_env - test.test_launcher.TestLauncher.test_virtualenv_with_env
  • test_literal_shebang_command - test.test_launcher.TestLauncher.test_literal_shebang_command
  • test_py_default_short_argv0 - test.test_launcher.TestLauncher.test_py_default_short_argv0
  • test_shebang_command_in_venv - test.test_launcher.TestLauncher.test_shebang_command_in_venv
  • test_search_major_3 - test.test_launcher.TestLauncher.test_search_major_3

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 465, in test_search_major_2
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 511, in test_py_default_short_argv0
    data = self.run_py(["--version"], argv=f'{argv0} --version')
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 787, in test_shebang_command_in_venv
    data = self.run_py([script], env=env)
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 309, in tearDownClass
    delete_registry_data(key, TEST_DATA)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 129, in delete_registry_data
    with winreg.OpenKey(root, key, access=ACCESS) as hkey:
         ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 2] The system cannot find the file specified


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 751, in test_literal_shebang_command
    self.assertEqual(
    ~~~~~~~~~~~~~~~~^
        f"TEST_EXE.exe arg1 {quote(script)}",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        data["stdout"].strip(),
        ^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 'TEST_EXE.exe arg1 C:\\Users\\Administrato[97 chars]p.py' != 'C:\\Users\\Administrator\\buildarea\\3.x.[207 chars]p.py'
- TEST_EXE.exe arg1 C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\build\test_python_6840æ\tmpz5y16zmp.py
+ C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\build\test_python_6840æ\test-command arg1 C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\build\test_python_6840æ\tmpz5y16zmp.py


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 552, in test_virtualenv_with_env
    data2 = self.run_py(["-V:PythonTestSuite/3"], env={**env, "PY_PYTHON": "PythonTestSuite/3"})
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 445, in test_search_major_3
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 652, in test_py_handle_64_in_ini
    data = self.run_py([], allow_fail=True, expect_returncode=103)
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 252, in run_py
    raise subprocess.CalledProcessError(p.returncode, [self.py_exe, *args], out, err)
subprocess.CalledProcessError: Command '[WindowsPath('C:/Users/Administrator/buildarea/3.x.itamaro-win64-srv-22-aws.x64.nogil/build/PCbuild/amd64/py_d.exe')]' returned non-zero exit status 0.

lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
… WASI (python#138203)

macOS by default doesn't have the requisite CLI tools to make a default value easy. Plus Tools/wasm/wasi takes care of setting HOSTRUNNER.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.15 new features, bugs and security fixes build The build process and cross-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants