Skip to content

Conversation

@asottile
Copy link
Contributor

Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile Now we just have to figure out why CI fails.

@warsaw
Copy link
Member

warsaw commented May 29, 2019

Looks like a permission problem on Windows.

@asottile
Copy link
Contributor Author

interesting, I guess we need to catch that too in importlib-metadata. I'll iterate here and then backport that to importlib-metadata 🤦‍♂️

@asottile
Copy link
Contributor Author

sweet windows passed, I'll go make the same PR to importlib-metadata :D

@warsaw warsaw merged commit 8087831 into python:master May 30, 2019
@bedevere-bot
Copy link

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

@asottile asottile deleted the importlib_metadata_cross_port_PR_72 branch June 1, 2019 01:24
vuno-bmkim pushed a commit to vuno-bmkim/importlib_metadata that referenced this pull request Sep 16, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
…#13667)

* Don't crash if there exists an EGG-INFO directory on sys.path

cross-port of https://gitlab.com/python-devs/importlib_metadata/merge_requests/72

* Also catch PermissionError for windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants