Don't crash if there exists an EGG-INFO directory on sys.path - [merged]

[jaraco]

In GitLab by @asottile on May 29, 2019, 21:11

Merges no_crash_is_a_directory -> master

A crazy intersection of bugs lead to this:

• https://bugs.python.org/issue37089
• Permission denied on Windows: EGG-INFO (regression in pluggy 0.12) pytest-dev/pluggy#219
• A weird package which writes a bogus EGG-INFO directory to the root of the prefix

[jaraco]

In GitLab by @asottile on May 29, 2019, 21:13

Commented on importlib_metadata/init.py line 391

I wasn't sure how to format this, the flake8 rules aren't the standard ones on this project -- this was the only form I could get flake8 to allow

what I wanted to format as:

with suppress(
        FileNotFoundError, IsADirectoryError, 
        NotADirectoryError, KeyError,
):
    ...

[jaraco]

In GitLab by @asottile on May 29, 2019, 21:17

added 1 commit

• af6f049f - Don't crash if there exists an EGG-INFO directory on sys.path

Compare with previous version

[jaraco]

In GitLab by @asottile on May 29, 2019, 21:19

resolved all discussions

[jaraco]

In GitLab by @asottile on May 29, 2019, 21:22

added 1 commit

• 0225106f - Don't crash if there exists an EGG-INFO directory on sys.path

Compare with previous version

[jaraco]

In GitLab by @warsaw on May 29, 2019, 21:26

assigned to @warsaw

[jaraco]

In GitLab by @codecov on May 29, 2019, 21:26

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #72   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         191    191           
  Branches       18     18           
=====================================
  Hits          191    191

Impacted Files	Coverage Δ
importlib_metadata/_compat.py	100% <ø> (ø)	⬆️
importlib_metadata/__init__.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f90d38...d6b5a9a. Read the comment docs.

[jaraco]

In GitLab by @asottile on May 29, 2019, 21:29

noticed this is targetted at 1.0 -- we want to use importlib-metadata in pytest and would appreciate a release with this bugfix -- I'm happy to forward/backport this fix to cpython master as well if it looks good (noticed this got provisionally added to stdlib which is exciting!)

[jaraco]

In GitLab by @warsaw on May 29, 2019, 21:32

You could write that line as either

        with suppress(FileNotFoundError, IsADirectoryError,
                      NotADirectoryError, KeyError
                      ):

or

        with suppress(FileNotFoundError, IsADirectoryError,
                      NotADirectoryError, KeyError):

I'm fine with what you have too, although I'd at least prefer the exceptions to be sorted alphabetically.

[jaraco]

In GitLab by @warsaw on May 29, 2019, 21:34

I've added an 0.16 milestone and retargeted this MP. 1.0 will be for the version that's included in Python 3.8.0.

[jaraco]

In GitLab by @warsaw on May 29, 2019, 21:34

Let me know if you want to change that suppress() line or keep it as you have it. I can do a quick approval, merge, and tag (which triggers the PyPI upload).

[jaraco]

In GitLab by @asottile on May 29, 2019, 21:37

yep I can sort that, one sec :)