[price-pusher] Bug fix on revert and crash #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
0xfirefist
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve a bug that was reported by one of the consumers. The bug was that the code was crashing on revert and the service didn't handle it well (it was a different message). Because of this bug there was another bug that the service was sending a transaction again and again because of the restart.
This PR updates the error handling to capture all messages containing "revert" and also waits for cooldown seconds before starting to push.
Also, some peoples reported that due to bad RPC they got error on the step that gets the
updateFeeand for some reason the error message was not caught (as this was not handled). This PR solves that too.