[price-pusher] Bug fix on revert and crash (#652)

Author: ali-behjati

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@pythnetwork/pyth-evm-price-pusher",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "Pyth EVM Price Pusher",
   "homepage": "https://pyth.network",
   "main": "lib/index.js",

price_pusher/package.json

@@ -22,6 +22,11 @@ export class Controller {
     await this.sourcePriceListener.start();
     await this.targetPriceListener.start();
 
+    // wait for the listeners to get updated. There could be a restart
+    // before this run and we need to respect the cooldown duration as
+    // their might be a message sent before.
+    await sleep(this.cooldownDuration * 1000);
+
     for (;;) {
       const pricesToPush: PriceConfig[] = [];
       const pubTimesToPush: UnixTimestamp[] = [];

price_pusher/src/controller.ts

@@ -150,10 +150,20 @@ export class EvmPricePusher implements IPricePusher {
       "Pushing ",
       priceIdsWith0x.map((priceIdWith0x) => `${priceIdWith0x}`)
     );
-    const updateFee = await this.pythContract.methods
-      .getUpdateFee(priceFeedUpdateData)
-      .call();
-    console.log(`Update fee: ${updateFee}`);
+
+    let updateFee;
+
+    try {
+      updateFee = await this.pythContract.methods
+        .getUpdateFee(priceFeedUpdateData)
+        .call();
+      console.log(`Update fee: ${updateFee}`);
+    } catch (e: any) {
+      console.error(
+        "An unidentified error has occured when getting the update fee:"
+      );
+      throw e;
+    }
 
     const gasPrice = await this.customGasStation?.getCustomGasPrice();
 
@@ -168,11 +178,7 @@ export class EvmPricePusher implements IPricePusher {
         console.log(`Successful. Tx hash: ${hash}`);
       })
       .on("error", (err: Error, receipt?: TransactionReceipt) => {
-        if (
-          err.message.includes(
-            "VM Exception while processing transaction: revert"
-          )
-        ) {
+        if (err.message.includes("revert")) {
           // Since we are using custom error structs on solidity the rejection
           // doesn't return any information why the call has reverted. Assuming that
           // the update data is valid there is no possible rejection cause other than