doc for _capturing_for_request #6698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
changed the title
bluetech
reviewed
Feb 12, 2020
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
An argument in favor of keeping it inside the CaptureManager class is that it sets and accesses internal details of CaptureManager, and is basically its "heart", so and it's nice to have it encapsulated.
Contributor
Author
Makes sense. The main motivation was to have less (duplicated) boilerplate code mainly. Pulled 5cd2214 out. |
Based on the removed doc for `_install_capture_fixture_on_item`. Follow-up to pytest-dev#6663. Update src/_pytest/capture.py [ci skip] Co-Authored-By: Ran Benita <[email protected]>
blueyed
changed the title
bluetech
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6663.