capture: cleanup item fixture handling #6663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This started by looking at how to get the current test item in general, and then I noticed that it is not necessary for the capture plugin to track it manually in the first place.
RonnyPfannschmidt
approved these changes
Feb 3, 2020
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
AFAIK this is practically an internal api, so the change is fine
Contributor
Author
|
Thanks for the review. The functions are at least not in the docs apparently, as Would like to get @nicoddemus's opinion also, given that I've seen him doing work in that area. |
nicoddemus
requested changes
Feb 6, 2020
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks! Indeed this looks better.
Please consider my naming suggestions though. 👍
Contributor
Author
|
Pushed a fixup with 2/3 suggestions applied. |
nicoddemus
approved these changes
Feb 7, 2020
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Feb 9, 2020
Based on the removed doc for `_install_capture_fixture_on_item`. Follow-up to pytest-dev#6663.
This was referenced Feb 9, 2020
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Feb 12, 2020
Based on the removed doc for `_install_capture_fixture_on_item`. Follow-up to pytest-dev#6663. Update src/_pytest/capture.py [ci skip] Co-Authored-By: Ran Benita <[email protected]>
blueyed
added a commit
that referenced
this pull request
Feb 13, 2020
Based on the removed doc for `_install_capture_fixture_on_item`. Follow-up to #6663. Co-authored-by: Ran Benita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started by looking at how to get the current test item in general,
and then I noticed that it is not necessary for the capture plugin to
track it manually in the first place.
Changes the API for
CaptureManager.*_fixturemethods (does not take itemanymore). This could be kept / ignored if required.