Skip to content

[4.6] ci: Travis: configure/restrict branch builds #6033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[4.6] ci: Travis: configure/restrict branch builds #6033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,3 +166,10 @@ notifications:
skip_join: true
email:
- [email protected]

branches:
only:
- master
- features
- 4.6-maintenance
- /^\d+(\.\d+)+$/
Copy link
Member

@asottile asottile Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually add another explicit pattern in case people need to actually play with CI (especially useful in forks)

Copy link
Contributor Author

@blueyed blueyed Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care to share?

Copy link
Member

@asottile asottile Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pre-commit/pre-commit/blob/7728162d7a47f387187e379b8011b224b168555d/azure-pipelines.yml#L3

Copy link
Contributor Author

@blueyed blueyed Oct 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you mean to include a prefix "test-me-*"?

I cannot really see why that would be useful - forks then have to use branches "test-me-foo" to have Travis run for their branch pushes, right?
The idea is that push branches for a "foo" branch are not run with this config, right?

I think real forks should also override that config then.

Regarding your use case we should just exclude "/^.-patch-./" only then?

btw: it would make more sense to discuss this on the master PR - I've only created this already, because I've thought it would be easy/non-controversial.

=> #6032 (comment)