Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 22, 2019

No description provided.

- master
- features
- 4.6-maintenance
- /^\d+(\.\d+)+$/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually add another explicit pattern in case people need to actually play with CI (especially useful in forks)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care to share?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@blueyed blueyed Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you mean to include a prefix "test-me-*"?

I cannot really see why that would be useful - forks then have to use branches "test-me-foo" to have Travis run for their branch pushes, right?
The idea is that push branches for a "foo" branch are not run with this config, right?

I think real forks should also override that config then.

Regarding your use case we should just exclude "/^.-patch-./" only then?

btw: it would make more sense to discuss this on the master PR - I've only created this already, because I've thought it would be easy/non-controversial.

=> #6032 (comment)

@blueyed blueyed closed this Oct 25, 2019
@blueyed blueyed deleted the ci-branches-4.6 branch October 25, 2019 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants