Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Dec 10, 2018

No description provided.

s0undt3ch and others added 19 commits December 1, 2018 21:40
Logging done late enough might happen when capture already stopped.
…_pitfall_1495

Document doctest fixture pitfalls
Ensure that PYTEST_ADDOPTS and addopts ini values are valid by themselves.
Started to fail on py37-xdist between
https://travis-ci.org/pytest-dev/pytest/jobs/465498973 and
https://travis-ci.org/pytest-dev/pytest/jobs/465792343, but could not
find a diff in versions (from the tox header), and both commits failed
locally.
@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #4524 into features will decrease coverage by 53.28%.
The diff coverage is 21.42%.

Impacted file tree graph

@@              Coverage Diff              @@
##           features    #4524       +/-   ##
=============================================
- Coverage     95.74%   42.46%   -53.29%     
=============================================
  Files           111       92       -19     
  Lines         24897    20887     -4010     
  Branches       2457     2348      -109     
=============================================
- Hits          23838     8869    -14969     
- Misses          748    11419    +10671     
- Partials        311      599      +288
Flag Coverage Δ
#docs 29.28% <21.42%> (-0.03%) ⬇️
#doctesting 29.28% <21.42%> (-0.03%) ⬇️
#linting 29.28% <21.42%> (-0.03%) ⬇️
#linux 42.46% <21.42%> (-53.11%) ⬇️
#nobyte ?
#numpy 40.84% <21.42%> (-52.36%) ⬇️
#pexpect 40.84% <21.42%> (-0.87%) ⬇️
#py27 40.84% <21.42%> (-52.94%) ⬇️
#py34 ?
#py35 ?
#py36 ?
#py37 ?
#trial 40.84% <21.42%> (-52.36%) ⬇️
#windows ?
#xdist ?
Impacted Files Coverage Δ
testing/test_capture.py 0% <0%> (-99.24%) ⬇️
testing/test_config.py 0% <0%> (-99.44%) ⬇️
src/_pytest/capture.py 71.49% <50%> (-22.39%) ⬇️
src/_pytest/config/__init__.py 67.82% <71.42%> (-26.32%) ⬇️
testing/test_pastebin.py 0% <0%> (-100%) ⬇️
testing/test_resultlog.py 0% <0%> (-100%) ⬇️
testing/test_entry_points.py 0% <0%> (-100%) ⬇️
testing/test_doctest.py 0% <0%> (-100%) ⬇️
testing/test_runner_xunit.py 0% <0%> (-100%) ⬇️
testing/test_pathlib.py 0% <0%> (-100%) ⬇️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76884c7...539d3dc. Read the comment docs.

@blueyed blueyed merged commit 038f1f9 into pytest-dev:features Dec 10, 2018
@blueyed blueyed deleted the merge-master branch December 10, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants