Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Dec 10, 2018

Started to fail on py37-xdist between
https://travis-ci.org/pytest-dev/pytest/jobs/465498973 and
https://travis-ci.org/pytest-dev/pytest/jobs/465792343, but could not
find a diff in versions (from the tox header), and both commits failed
locally.

Started to fail on py37-xdist between
https://travis-ci.org/pytest-dev/pytest/jobs/465498973 and
https://travis-ci.org/pytest-dev/pytest/jobs/465792343, but could not
find a diff in versions (from the tox header), and both commits failed
locally.
@blueyed
Copy link
Contributor Author

blueyed commented Dec 10, 2018

Pulling into #4524.

@blueyed blueyed closed this Dec 10, 2018
@blueyed blueyed deleted the fix-test_raises_exception_looks_iterable branch December 10, 2018 05:28
@blueyed blueyed restored the fix-test_raises_exception_looks_iterable branch December 10, 2018 05:29
@blueyed blueyed reopened this Dec 10, 2018
@blueyed
Copy link
Contributor Author

blueyed commented Dec 10, 2018

Well, should go into master also, of course.

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #4525 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4525      +/-   ##
==========================================
+ Coverage   95.84%   95.91%   +0.07%     
==========================================
  Files         111      111              
  Lines       25110    25110              
  Branches     2449     2449              
==========================================
+ Hits        24067    24085      +18     
+ Misses        735      723      -12     
+ Partials      308      302       -6
Flag Coverage Δ
#docs 30.07% <ø> (+0.98%) ⬆️
#doctesting 30.07% <ø> (+0.98%) ⬆️
#linting 30.07% <ø> (+0.98%) ⬆️
#linux 95.74% <ø> (+0.06%) ⬆️
#nobyte 92.67% <ø> (+0.62%) ⬆️
#numpy 93.45% <ø> (+51.61%) ⬆️
#pexpect 41.83% <ø> (ø) ⬆️
#py27 94.05% <ø> (+0.01%) ⬆️
#py34 92.2% <ø> (?)
#py35 92.21% <ø> (?)
#py36 92.23% <ø> (?)
#py37 94.12% <ø> (+0.29%) ⬆️
#trial 93.45% <ø> (+51.61%) ⬆️
#windows 94.13% <ø> (+0.6%) ⬆️
#xdist 93.97% <ø> (ø) ⬆️
Impacted Files Coverage Δ
testing/python/raises.py 93.75% <ø> (ø) ⬆️
src/_pytest/capture.py 94.11% <0%> (+0.45%) ⬆️
testing/test_pdb.py 99.02% <0%> (+0.48%) ⬆️
src/_pytest/assertion/rewrite.py 95.7% <0%> (+0.49%) ⬆️
src/_pytest/terminal.py 92.95% <0%> (+0.83%) ⬆️
src/_pytest/compat.py 96.87% <0%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb0dfc...5ecbb02. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #4525 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4525      +/-   ##
==========================================
+ Coverage   95.84%   95.91%   +0.07%     
==========================================
  Files         111      111              
  Lines       25110    25110              
  Branches     2449     2449              
==========================================
+ Hits        24067    24085      +18     
+ Misses        735      723      -12     
+ Partials      308      302       -6
Flag Coverage Δ
#docs 30.07% <ø> (+0.98%) ⬆️
#doctesting 30.07% <ø> (+0.98%) ⬆️
#linting 30.07% <ø> (+0.98%) ⬆️
#linux 95.74% <ø> (+0.06%) ⬆️
#nobyte 92.67% <ø> (+0.62%) ⬆️
#numpy 93.45% <ø> (+51.61%) ⬆️
#pexpect 41.83% <ø> (ø) ⬆️
#py27 94.05% <ø> (+0.01%) ⬆️
#py34 92.2% <ø> (?)
#py35 92.21% <ø> (?)
#py36 92.23% <ø> (?)
#py37 94.12% <ø> (+0.29%) ⬆️
#trial 93.45% <ø> (+51.61%) ⬆️
#windows 94.13% <ø> (+0.6%) ⬆️
#xdist 93.97% <ø> (ø) ⬆️
Impacted Files Coverage Δ
testing/python/raises.py 93.75% <ø> (ø) ⬆️
src/_pytest/capture.py 94.11% <0%> (+0.45%) ⬆️
testing/test_pdb.py 99.02% <0%> (+0.48%) ⬆️
src/_pytest/assertion/rewrite.py 95.7% <0%> (+0.49%) ⬆️
src/_pytest/terminal.py 92.95% <0%> (+0.83%) ⬆️
src/_pytest/compat.py 96.87% <0%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb0dfc...5ecbb02. Read the comment docs.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicoddemus nicoddemus merged commit 22345ef into pytest-dev:master Dec 10, 2018
@blueyed blueyed deleted the fix-test_raises_exception_looks_iterable branch December 11, 2018 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants