Skip to content

Conversation

@asottile
Copy link
Member

@asottile asottile commented Oct 9, 2018

broken in #4089

will revert after virtualenv releases with upgrade pip which should fix the installation issue

@asottile asottile merged commit c55d641 into master Oct 9, 2018
@asottile asottile deleted the asottile/asottile-patch-1 branch October 9, 2018 05:55
@nicoddemus
Copy link
Member

Hmm does this mean that Windows users like me cannot run tox -e linting anymore?

@asottile
Copy link
Member Author

asottile commented Oct 9, 2018

hmmm yeah that is unfortunate -- I'll see what I can do to get this re-enabled without waiting for virtualenv

@RonnyPfannschmidt
Copy link
Member

@asottile wouldnt it make sense to move black from python to python-venv? - its python3 only anyway

@asottile
Copy link
Member Author

asottile commented Oct 9, 2018

😆 then it wouldn't work on my machine (debian) -- python-venv also wouldn't fix it, the real problem is pip 10.x can't install black on windows. new virtualenv will have new pip.

@asottile
Copy link
Member Author

asottile commented Oct 9, 2018

here's a PR which reverts back to the old black version which should work until we get a new virtualenv release: #4099

@RonnyPfannschmidt
Copy link
Member

@asottile ouch - version hell is a true hell ^^ - thanks for the hard work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants