-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Upgrade pre-commit hooks #4089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pre-commit hooks #4089
Conversation
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job, please take a look at the string join
|
hrmmm, seem to be hitting pre-commit/pre-commit#835 (which itself is an intersection of pip / virtualenv / black / windows) |
|
I think this might magically fix itself when |
|
great work :) |
|
@RonnyPfannschmidt oh uh, this breaks the couple of options:
|
|
@asottile oh, my bad - lets disable linting on windows and create a followup issue for after virtualenv releases |
No description provided.