Skip to content

Conversation

@asottile
Copy link
Member

@asottile asottile commented Oct 8, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.809% when pulling 65545d8 on asottile:upgrade_hooks into 6660966 on pytest-dev:master.

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, please take a look at the string join

@asottile
Copy link
Member Author

asottile commented Oct 8, 2018

hrmmm, seem to be hitting pre-commit/pre-commit#835 (which itself is an intersection of pip / virtualenv / black / windows)

@asottile
Copy link
Member Author

asottile commented Oct 9, 2018

I think this might magically fix itself when virtualenv makes a release. So I'm going to wait on that :)

@RonnyPfannschmidt RonnyPfannschmidt merged commit 8393fdd into pytest-dev:master Oct 9, 2018
@RonnyPfannschmidt
Copy link
Member

great work :)

@asottile
Copy link
Member Author

asottile commented Oct 9, 2018

@RonnyPfannschmidt oh uh, this breaks the linting env on windows -- I wasn't quite ready to merge it yet 😆

couple of options:

  • temporarily disable linting on windows (should be fixed by the end of the week once virtualenv releases if my hunch is right)
  • upgrade the linting env to python3.7 (should use UTF-8 mode I think?)
  • revert-revert and then I can re-apply later

@asottile asottile deleted the upgrade_hooks branch October 9, 2018 05:46
@RonnyPfannschmidt
Copy link
Member

@asottile oh, my bad - lets disable linting on windows and create a followup issue for after virtualenv releases

@asottile
Copy link
Member Author

asottile commented Oct 9, 2018

no problem! I made #4094 and #4095 to handle this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants