Skip to content

Fix ImportWarning triggered by explicit relative imports #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2018
Merged

Fix ImportWarning triggered by explicit relative imports #3613

merged 2 commits into from
Jun 23, 2018

Conversation

@asottile
Copy link
Member

@asottile asottile commented Jun 23, 2018

Resolves #3061

nicoddemus
nicoddemus approved these changes Jun 23, 2018
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @asottile!

@coveralls
Copy link

coveralls commented Jun 23, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 92.677% when pulling 17985b8 on asottile:module_spec_warnings into 630428c on pytest-dev:master.

@asottile
Copy link
Member Author

asottile commented Jun 23, 2018

oh actually I think I should partially revert #3096 as well

@nicoddemus nicoddemus merged commit 50a0d4f into pytest-dev:master Jun 23, 2018
@asottile asottile deleted the module_spec_warnings branch June 23, 2018 22:57
@jccurtis jccurtis mentioned this pull request Oct 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asottile @coveralls @RonnyPfannschmidt @nicoddemus