Ignore ImportWarnings regarding package resolution #3096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
asottile
approved these changes
Jan 8, 2018
Member
asottile
left a comment
asottile
left a comment
There was a problem hiding this comment.
+1 to merging this to unblock builds
we should fix the root cause (whatever it is) and then remove this. Perhaps a comment indicating that with a ticket link here would be helpful?
The problem is described/discussed in pytest-dev#3061 Ideally this should be a temporary solution until we find a proper one which gets rid of the warning
Member
Author
|
@asottile agreed. I will now see what's the matter with |
nicoddemus
force-pushed
the
import-warnings
branch
from
4af623e to
76316dc
Compare
Since 0.6.1 pluggy has been turned into a package
nicoddemus
force-pushed
the
import-warnings
branch
from
76316dc to
b6b36bc
Compare
Member
Author
|
Merging to unblock PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is described/discussed in #3061
Ideally this should be a temporary solution until we find a proper one
which gets rid of the warning