-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
update-plugin-list: use json, use http caching, use gh action caches #10927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-plugin-list: use json, use http caching, use gh action caches #10927
Conversation
|
This is interesting, but I wonder if we need to speed up this workflow at all? This runs only once a week, and looking at the list of runs, each run takes only around 4m or less. |
|
When I hacked on it to use json, the feedback time was a pain, adding the cache made it a breeze to run |
|
Got it, thanks! |
604621e to
50a3176
Compare
50a3176 to
bf7c2d1
Compare
|
fixing the false cache-hit issue wrt last-serial made it more complicated, lets reeval |
bluetech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing the false cache-hit issue wrt last-serial made it more complicated, lets reeval
Didn't realize requests-cache ignores the cache-control header by default. The fix LGTM.
|
@bluetech it's not that it ignores it, it's just that the default cache controls lead to stale data, one needs to compare extra data to force a refresh None of the http standard caching tools enable the required data pass over, so manual intervention is needed |
bf7c2d1 to
c783f1c
Compare
this change * switches from html index usage to json index usage * adds using requests-cache as http cache to trim down runtime * adds gh action caches for pip and the new http cache
80383d9 to
1ded747
Compare
this change