Skip to content

Conversation

@RonnyPfannschmidt
Copy link
Member

this change

  • switches from html index usage to json index usage
  • adds using requests-cache as http cache to trim down runtime
  • adds gh action caches for pip and the new http cache

@nicoddemus
Copy link
Member

This is interesting, but I wonder if we need to speed up this workflow at all? This runs only once a week, and looking at the list of runs, each run takes only around 4m or less.

@RonnyPfannschmidt
Copy link
Member Author

When I hacked on it to use json, the feedback time was a pain, adding the cache made it a breeze to run

@nicoddemus
Copy link
Member

Got it, thanks!

@RonnyPfannschmidt
Copy link
Member Author

fixing the false cache-hit issue wrt last-serial made it more complicated, lets reeval

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing the false cache-hit issue wrt last-serial made it more complicated, lets reeval

Didn't realize requests-cache ignores the cache-control header by default. The fix LGTM.

@RonnyPfannschmidt
Copy link
Member Author

@bluetech it's not that it ignores it, it's just that the default cache controls lead to stale data, one needs to compare extra data to force a refresh

None of the http standard caching tools enable the required data pass over, so manual intervention is needed

this change
* switches from html index usage to json index usage
* adds using requests-cache as http cache to trim down runtime
* adds gh action caches for pip and the new http cache
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the pypi-json-for-plugin-list branch from 80383d9 to 1ded747 Compare July 20, 2023 13:04
@nicoddemus nicoddemus merged commit ffdcce6 into pytest-dev:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants