Skip to content

Conversation

@abravalheri
Copy link
Contributor

Summary of changes

According to pypa/distutils#118, we need to pass the following variables when compiling C-extensions on Windows:

  • PROGRAMDATA
  • PROGRAMFILES
  • PROGRAMFILES(x86)

(compiler specific - VisualC++)

Closes #3135

(Second attempt, in #3168 PROGRAMDATA was not passed)

Pull Request Checklist

According to a comment in pypa/distutils#118 this problem might be
solved by allowing tox to pass some environment variables.
@abravalheri abravalheri changed the title Attempt to re-enable Windows tests [CI] Attempt to update Windows hosts Mar 17, 2022
@abravalheri abravalheri marked this pull request as ready for review March 17, 2022 17:22
@abravalheri abravalheri merged commit 8723db4 into pypa:main Mar 20, 2022
@abravalheri abravalheri deleted the ci/update-windows-host branch March 20, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] test_build_ext.py is regularly failing on Windows: Microsoft Visual C++ 14.0 or greater is required

1 participant