Support non-ascii cwds in make_subprocess_output_error() #6683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
C: encoding
cjerdonek
force-pushed
the
make-subprocess-error-path-display
branch
from
bc6f700 to
6c0026f
Compare
cjerdonek
force-pushed
the
make-subprocess-error-path-display
branch
from
6c0026f to
77ad476
Compare
xavfernandez
approved these changes
Jul 8, 2019
Member
Author
|
Thanks, @xavfernandez. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on to PR #6671 to fix another potential Python 2
strissue in PR #6655.Currently,
make_subprocess_output_error()will raise aUnicodeDecodeErrorlike the following when callingstr.format()if thecwdcontains a non-ascii character:This PR fixes that issue by safely converting the
cwdto text (unicodein Python 2) before callingstr.format(). It does this by introducing apath_to_display()function that is similar to thestr_to_display()function introduced in PR #6671, except tailored to paths rather than to general bytes objects.