Skip to content

Fix #6651: Improve error message formatting when a command errors out #6655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

Fix #6651: Improve error message formatting when a command errors out #6655

merged 1 commit into from
Jun 27, 2019

Conversation

@cjerdonek
Copy link
Member

@cjerdonek cjerdonek commented Jun 27, 2019

Fixes #6651.

@cjerdonek cjerdonek added C: logging Information Logging type: bugfix labels Jun 27, 2019
@cjerdonek cjerdonek mentioned this pull request Jun 27, 2019
Closed
@cjerdonek cjerdonek force-pushed the issue-6651-subprocess-output-formatting branch from 2865fea to 5955fa6 Compare June 27, 2019 08:49
@cjerdonek cjerdonek force-pushed the issue-6651-subprocess-output-formatting branch from 5955fa6 to 9eab352 Compare June 27, 2019 10:06
pradyunsg
pradyunsg approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me likey! =D

@cjerdonek cjerdonek merged commit 13d3de2 into pypa:master Jun 27, 2019
@cjerdonek cjerdonek deleted the issue-6651-subprocess-output-formatting branch June 27, 2019 16:53
This was referenced Jul 2, 2019
Merged
Merged
@cjerdonek cjerdonek mentioned this pull request Jul 25, 2019
Closed
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jul 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees

No one assigned

Labels

auto-locked Outdated issues that have been locked by automation C: logging Information Logging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Called process error output doesn’t all go to stderr

3 participants

@cjerdonek @xavfernandez @pradyunsg