Skip to content

Complete type annotations in pip/_internal/cli #10169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Complete type annotations in pip/_internal/cli #10169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f0556d
complete type annotations in _internal/cli
harupy Jul 17, 2021
d075114
use empty string by default
harupy Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pip/_internal/cli/autocompletion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def autocomplete() -> None:
options = []

# subcommand
subcommand_name = None # type: Optional[str]
subcommand_name: Optional[str] = None
for word in cwords:
if word in subcommands:
subcommand_name = word
Expand Down
6 changes: 3 additions & 3 deletions src/pip/_internal/cli/base_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@


class Command(CommandContextMixIn):
usage = None # type: str
ignore_require_venv = False # type: bool
usage: str = ""
ignore_require_venv: bool = False

def __init__(self, name: str, summary: str, isolated: bool = False) -> None:
super().__init__()
Expand All @@ -58,7 +58,7 @@ def __init__(self, name: str, summary: str, isolated: bool = False) -> None:
isolated=isolated,
)

self.tempdir_registry = None # type: Optional[TempDirRegistry]
self.tempdir_registry: Optional[TempDirRegistry] = None

# Commands should add options to this option group
optgroup_name = f"{self.name.capitalize()} Options"
Expand Down
Loading