Complete type annotations in pip/_internal/cli
#10169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @harupy. Thanks for completing my previous jobs! I only converted the type commentaries on functions (and some variables), so I (personally) appreciate your help. |
Contributor
Author
|
@DiddiLeija No problem! |
uranusjr
reviewed
Jul 22, 2021
|
|
||
|
|
||
| use_pep517 = partial( | ||
| use_pep517: Any = partial( |
Member
There was a problem hiding this comment.
I wonder why this (and the one below) is Any instead of Callable[..., Option].
Member
Member
There was a problem hiding this comment.
Yeah, I'm more like trying to get into the mind of the person who wrote the original annotation (because all others are Callable[..., Option], persumably they should know this is possible).
uranusjr
approved these changes
Jul 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete type annotations in
pip/_internal/cli.