Skip to content

Conversation

@DiddiLeija
Copy link
Member

Convert these type hint commentaries into proper annotations.

I started from appdirs.py, because it seems like _log.py was already converted by commit c87af08. I don't know if other files were converted before I am checking them, but I will try to fix the incomplete annotations.

Convert these type hint commentaries into proper annotations.
This is the news entry for my pull request.
Fix them at "compatibility_tags.py".
@DiddiLeija
Copy link
Member Author

An unexpected error happened with the CI / tests / 3.9 / Windows / 1 (pull_request) test:

Run ./tools/ci/New-RAMDisk.ps1 -Drive R -Size 1GB
Installing FS-iSCSITarget-Server

Success Restart Needed Exit Code      Feature Result
------- -------------- ---------      --------------
True    No             NoChangeNeeded {}
Starting MSiSCSI
WARNING: Waiting for service 'Microsoft iSCSI Initiator Service (MSiSCSI)' to start...
Configuring Firewall
Configuring RAMDisk
New-IscsiServerTarget: C:\Users\runneradmin\AppData\Local\Temp\remoteIpMoProxy_IscsiTarget_2.0.0.0_localhost_d3c7e070-6ef5-40fc-8251-c629f5644ece\remoteIpMoProxy_IscsiTarget_2.0.0.0_localhost_d3c7e070-6ef5-40fc-8251-c629f5644ece.psm1:1731
Line |
1731 |          $steppablePipeline.End()
     |          ~~~~~~~~~~~~~~~~~~~~~~~~
     | An unexpected error occurred.

Error: Process completed with exit code 1.

What can I do on this case?

@DiddiLeija
Copy link
Member Author

Hmm... On my latest commit, no such tests failed. Maybe a bug occurred. Anyway, I think I can continue with this work now.

Fix them on "deprecation.py".
It required a comma.
Fix them at "direct_url_helpers.py".
Fix them at "distutils_args.py".
Fix them at "encoding.py".
Fix them at "entrypoints.py".
The black tests were failing on this annotation.
Fix them at "filesystem.py".
It was written incorrectly.
@DiddiLeija
Copy link
Member Author

Even when there are a lot of files to complete here, I think we can stop here by now, and finish on another PR. What do you think, @uranusjr?

@uranusjr
Copy link
Member

Sounds good to me. I'm going through the issues and PRs right now, will come back and merge later.

@uranusjr
Copy link
Member

CI seems stuck

@uranusjr uranusjr closed this Jul 23, 2021
@uranusjr uranusjr reopened this Jul 23, 2021
@uranusjr
Copy link
Member

Oops, it seems like resolving conflicts on GitHub UI breaks our CI triggers. Could you rebase or force-push this branch to re-trigger things? (Also #10169)

@pradyunsg
Copy link
Member

CI seems to have recovered now.

@uranusjr
Copy link
Member

Nice

@uranusjr uranusjr merged commit e689113 into pypa:main Jul 23, 2021
@DiddiLeija
Copy link
Member Author

Thanks @uranusjr for merging! I didn't have time enough for checking this, but thanks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants