-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Complete the annotations: pip/_internal/utils
#10159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete the annotations: pip/_internal/utils
#10159
Conversation
Convert these type hint commentaries into proper annotations.
This is the news entry for my pull request.
Fix them on "compat.py".
Fix them at "compatibility_tags.py".
Fix them at "datetime.py".
|
An unexpected error happened with the What can I do on this case? |
|
Hmm... On my latest commit, no such tests failed. Maybe a bug occurred. Anyway, I think I can continue with this work now. |
Fix them on "deprecation.py".
It required a comma.
Fix them at "direct_url_helpers.py".
Fix them at "distutils_args.py".
Fix them at "encoding.py".
Fix them at "entrypoints.py".
The black tests were failing on this annotation.
Fix them at "filesystem.py".
It was written incorrectly.
|
Even when there are a lot of files to complete here, I think we can stop here by now, and finish on another PR. What do you think, @uranusjr? |
|
Sounds good to me. I'm going through the issues and PRs right now, will come back and merge later. |
|
CI seems stuck |
|
Oops, it seems like resolving conflicts on GitHub UI breaks our CI triggers. Could you rebase or force-push this branch to re-trigger things? (Also #10169) |
|
CI seems to have recovered now. |
|
Nice |
|
Thanks @uranusjr for merging! I didn't have time enough for checking this, but thanks. |
Convert these type hint commentaries into proper annotations.
I started from
appdirs.py, because it seems like_log.pywas already converted by commit c87af08. I don't know if other files were converted before I am checking them, but I will try to fix the incomplete annotations.