Skip to content

Conversation

@OriolAbril
Copy link
Member

I am switching the pydata-sphinx-theme to pymc-sphinx-theme.
It is a very thin wrapper over the pydata-sphinx-theme to abstract the common
logic between the 3 websites, so we don't need to make changes to the 3
repos every time we want to update something or something breaks.

Checklist

Docs / Maintenance

  • Change theme to pymc-sphinx-theme

Copy link
Member

@canyon289 canyon289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming docs build this looks good

@OriolAbril
Copy link
Member Author

It should build and 1) look the same + 2) have the same functionality. We have the check the preview very carefully for this PR

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #6296 (2075715) into main (5d7283e) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6296      +/-   ##
==========================================
+ Coverage   94.12%   94.17%   +0.05%     
==========================================
  Files         111      111              
  Lines       23861    23913      +52     
==========================================
+ Hits        22458    22520      +62     
+ Misses       1403     1393      -10     
Impacted Files Coverage Δ
pymc/step_methods/hmc/quadpotential.py 80.62% <0.00%> (-0.07%) ⬇️
pymc/tests/sampling/test_jax.py 100.00% <0.00%> (ø)
pymc/variational/opvi.py 87.08% <0.00%> (+0.02%) ⬆️
pymc/step_methods/hmc/nuts.py 97.31% <0.00%> (+0.05%) ⬆️
pymc/sampling/jax.py 97.34% <0.00%> (+0.14%) ⬆️
pymc/variational/callbacks.py 96.22% <0.00%> (+0.22%) ⬆️
pymc/blocking.py 95.34% <0.00%> (+0.22%) ⬆️
pymc/step_methods/hmc/hmc.py 92.98% <0.00%> (+0.25%) ⬆️
pymc/variational/operators.py 93.18% <0.00%> (+0.32%) ⬆️
pymc/model.py 90.32% <0.00%> (+0.63%) ⬆️
... and 3 more

@OriolAbril
Copy link
Member Author

Only yhe edit this page button seems to not be working. I'll take a look tomorrow

# documentation.

html_theme_options = {
"icon_links": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twiecki answering pymc-devs/pymc-examples#465 (comment) here. If you look at the preview you will see that the logos are still there. What is being removed is the triplication of this info. Now this is part of the pymc-sphinx-theme which inherits from pydata-sphinx-theme and sets up most of the common elements between al 3 main websittes (and others like pymc-experimental or pymc-bart)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants