Docstring update to pymc.DiscreteUniform #6288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6288 +/- ##
==========================================
+ Coverage 93.30% 94.30% +0.99%
==========================================
Files 111 111
Lines 23809 23809
==========================================
+ Hits 22216 22452 +236
+ Misses 1593 1357 -236
|
* Add a few missing type imports * Trade assert with assignment to keep mypy happy * Add a few type annotations * Add missing return type for __call__ * Switch comment type declaration to raw * Get operators.py to pass * Fix pymc.backends.report * Fix a bunch of typing issues * Import __future__.annotations to fix "| None" * Update pymc/step_methods/hmc/integration.py * Add __future__.annotations to hmc.py * Remove unused Any import * Don't cast float to np.array * Replace 0 with 0.0 for float zeros * Update pymc/step_methods/hmc/nuts.py Closes pymc-devs#6282 Co-authored-by: Adrian Seyboldt <[email protected]> Co-authored-by: Michael Osthege <[email protected]>
* tests for added sample statistics * sample stats test with more draws * redesigned test for older blackjax version * record blackjax sample stats * moved sample stats argument to partial call
* improve random seed processing * improve type-hint
Member
|
This looks good, but it looks like we have some more distributions with the same problem - at least Categorical and the ZeroInflatedBinomial are missing the @hyosubkim could you go through them and fix it there too? |
* remove dups, add type hints, and docstrings * replacing references to old code * reorder and reword * deprecate the "test_point" method * fix NameError. got to work locally
Merge branch 'docstring_update' of github.com:hyosubkim/pymc into docstring_update
Contributor
Author
|
@michaelosthege - I made the suggested fixes. Sorry for all the commits--I was running into some issues because my branch wasn't caught up to the remote and wasn't sure how to fix correctly at first. |
Member
|
superseded by #6301 if I'm not mistaken |
Contributor
Author
|
Yes, that's right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Added close-figs context and edited parameter descriptions.
Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance