-
Notifications
You must be signed in to change notification settings - Fork 2.2k
added close-figs context #6301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added close-figs context #6301
Conversation
|
@michaelosthege - tried to push the same commits on a different branch since I saw many of the checks had failed. Sorry I don't know why so many tests are failing |
michaelosthege
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glad you got the git problems sorted out!
Thanks for adding the remaining close-figs. I commented one thing that should fix the CI pipeline and then we're good to go
pymc/distributions/discrete.py
Outdated
|
|
||
|
|
||
| discrete_uniform = DiscreteUniformRV() | ||
| discrete_uniform = RV() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| discrete_uniform = RV() | |
| discrete_uniform = DiscreteUniformRV() |
Undoing this change should fix the CI pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. That seems to be it. Not sure how that change got in there, but I'll check the diffs more carefully next time.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6301 +/- ##
===========================================
- Coverage 90.89% 77.53% -13.37%
===========================================
Files 111 111
Lines 23913 23913
===========================================
- Hits 21736 18540 -3196
- Misses 2177 5373 +3196
|
michaelosthege
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
merging now...
|
Great. Thanks for the help. |
What is this PR about?
Added ":context: close-figs" after all instances of ".. plot::"
Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance