Skip to content

Conversation

@hyosubkim
Copy link
Contributor

What is this PR about?
Added ":context: close-figs" after all instances of ".. plot::"

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • ...

@hyosubkim
Copy link
Contributor Author

@michaelosthege - tried to push the same commits on a different branch since I saw many of the checks had failed. Sorry I don't know why so many tests are failing

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad you got the git problems sorted out!

Thanks for adding the remaining close-figs. I commented one thing that should fix the CI pipeline and then we're good to go



discrete_uniform = DiscreteUniformRV()
discrete_uniform = RV()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
discrete_uniform = RV()
discrete_uniform = DiscreteUniformRV()

Undoing this change should fix the CI pipeline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That seems to be it. Not sure how that change got in there, but I'll check the diffs more carefully next time.

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #6301 (c9d2ff6) into main (24888ac) will decrease coverage by 13.36%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6301       +/-   ##
===========================================
- Coverage   90.89%   77.53%   -13.37%     
===========================================
  Files         111      111               
  Lines       23913    23913               
===========================================
- Hits        21736    18540     -3196     
- Misses       2177     5373     +3196     
Impacted Files Coverage Δ
pymc/distributions/discrete.py 64.85% <50.00%> (-34.37%) ⬇️
pymc/tests/variational/test_updates.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/distributions/test_continuous.py 0.00% <0.00%> (-99.77%) ⬇️
pymc/tests/distributions/test_multivariate.py 0.00% <0.00%> (-99.46%) ⬇️
pymc/tests/backends/test_arviz.py 0.00% <0.00%> (-99.03%) ⬇️
pymc/tests/distributions/test_discrete.py 0.00% <0.00%> (-98.89%) ⬇️
pymc/tests/distributions/test_distribution.py 0.00% <0.00%> (-98.17%) ⬇️
pymc/variational/updates.py 37.93% <0.00%> (-54.19%) ⬇️
pymc/tests/distributions/util.py 43.70% <0.00%> (-47.17%) ⬇️
pymc/distributions/multivariate.py 57.77% <0.00%> (-34.51%) ⬇️
... and 25 more

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

merging now...

@michaelosthege michaelosthege added docs maintenance no releasenotes Skipped in automatic release notes generation labels Nov 15, 2022
@michaelosthege michaelosthege merged commit 07388bc into pymc-devs:main Nov 15, 2022
@hyosubkim
Copy link
Contributor Author

Great. Thanks for the help.

@hyosubkim hyosubkim deleted the second_docstring_update branch November 15, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs maintenance no releasenotes Skipped in automatic release notes generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants